Repository navigation
Refresh vulnerable dev dependencies in the lockfile - #1069
Merged
Merged
Conversation
Several open Dependabot security alerts were for transitive development dependencies whose fixed versions already satisfy their parents' version ranges, but the lockfile still held older copies and Dependabot had not raised updates for them. Refreshing js-yaml 4.x, @babel/core, ws and minimatch within their existing ranges, and deduplicating the stale nested copies under cosmiconfig and @wordpress/scripts, clears those alerts without touching package.json. All of these packages are build and test tooling, so nothing shipped in the plugin changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eight of the open Dependabot security alerts are for transitive development dependencies whose fixed versions already fit their parents' version ranges, but the lockfile still held older copies and Dependabot never raised updates for them. This PR refreshes
js-yaml4.x,@babel/core,wsandminimatchwithin their existing ranges, and removes the stale nested copies undercosmiconfigand@wordpress/scriptsso the current versions are used everywhere.package.jsonis untouched.That should close Dependabot alerts 309, 281, 265 and 238 (
js-yaml), 231 (@babel/core), 229 (ws), and 169 and 171 (minimatch). All of these are build and test tooling, so nothing shipped in the plugin changes.The remaining 13 alerts have been dismissed as a tolerable risk, because each fix needs a major version that the latest upstream parent doesn't allow yet. They cover
@wordpress/env(simple-git,got,js-yaml3),markdownlint-cli's pinnedsmol-tomlandjs-yaml5,katex,cssnano6'spostcss-selector-parser,serialize-javascriptvia@wordpress/scripts' webpack plugins, anduuidviasockjs. They're all development-only, and can be picked up when Gutenberg updates those packages.Test plan
npm cifrom the new lockfile, which resolves only from registry.npmjs.orgnpm run test-js: 18/18 passnpm run lint-jsandnpm run buildsucceeddevelop