Remove stale persistence-daemon comment and dead nvidia-persistenced.service#160
Open
ganeshkumarashok wants to merge 1 commit into
Open
Remove stale persistence-daemon comment and dead nvidia-persistenced.service#160ganeshkumarashok wants to merge 1 commit into
ganeshkumarashok wants to merge 1 commit into
Conversation
…service The "configure persistence daemon" comment was left behind when the custom nvidia-persistenced systemd unit was removed (Azure#105, since the NVIDIA runfile ships its own unit). The comment now misleadingly sits above the lib-copy added in Azure#106 (which fixed nvidia-smi missing libs, unrelated to persistence). Replace it with an accurate comment and drop the now-unused nvidia-persistenced.service file (still COPYed by the Dockerfile but never installed). No behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
# configure persistence daemoncomment block with an accurate one. The comment described the customnvidia-persistencedsystemd unit that was removed in Remove custom nvidia persistenced systemd unit #105 (the NVIDIA runfile ships its own unit at/lib/systemd/system/nvidia-persistenced.service). It has since sat misleadingly above thecp -r /usr/bin/lib64/lib64/*line added in Copy libs to different path for nvidia-smi #106 — which actually fixed nvidia-smi missing libs, unrelated to persistence.nvidia-persistenced.servicefile and itsDockerfileCOPY (shipped into the image but never installed since Remove custom nvidia persistenced systemd unit #105).Why
Pure cleanup to prevent future misattribution of the lib-copy line to persistence tuning. No behavior change.
Note on persistence
Enabling persistence mode (to speed up repeated
nvidia-smion multi-GPU SKUs) is intentionally out of scope here — it's a runtime behavior change that needs benchmarking on real 4/8-GPU hardware and verification thatsystemctlbehaves in the CSE install context. Tracked separately.