Consolidate Azure CLI credential instances in test helper - #7534
Open
damonbarry wants to merge 4 commits into
Open
Consolidate Azure CLI credential instances in test helper#7534damonbarry wants to merge 4 commits into
damonbarry wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surgical cherry-pick of 5317cde from the
release/1.5branch. This update optimizes our use of Azure CLI credentials in a helper class so tests don't needlessly invokeaz account get-access-tokenmultiple times. This was an important change for end-to-end tests on Debian 11/arm32v7 (1.5 only); the redundant credential commands don't seem to cause failures in 1.6 test runs, but there's no reason not to port over this small optimization.Also updated some missed packages.lock.json files.
With these changes, I confirmed the end-to-end tests pass.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines