-
Notifications
You must be signed in to change notification settings - Fork 0
changes in new-allocation-card #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
conwelld
wants to merge
35
commits into
department-portal-base
Choose a base branch
from
new-allocation-card
base: department-portal-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
9bd90f6
added changes from previous branch to avoid all files being commited
conwelld 56d5a29
fixed some pr comments
conwelld faf1957
fixed some pr comments for css styling
conwelld 1204269
fixed useless code
conwelld 0f166c2
fixed department code
conwelld 6f5850a
We have change the hard coded part with variable able to be flexible …
813f398
Temporary allocation logic will be replaced by the official shared se…
7584ffa
fix the review comment from Minran, all of them
DanielRukwasha e9a4415
Merge branch 'department-portal-base' into new-allocation-card, resol…
DanielRukwasha 20b424c
Fix import after allocationUtilization rename to getAllocation, add i…
DanielRukwasha ee0e066
Address PR review comments: consolidate getAllocation return dict, ex…
DanielRukwasha 6abd704
Merge branch 'department-portal-base' into new-allocation-card, resol…
DanielRukwasha 8618b68
Adopt approval-status filtering from UsedAllocFunction branch in getA…
DanielRukwasha a0ba238
Polish the allocation card: dynamic Fall/Spring term label, "X of Y" …
munsakad 86bee45
Merge branch 'department-portal-base' into new-allocation-card
munsakad 45b13e0
Fix duplicate main.managePositions endpoint left over from the depart…
munsakad 74bdd3a
Rework allocation rows to the "N hr: X contracts (out of Y allocation…
munsakad a7ca474
Address allocation card review: camelCase naming, stacked layout, con…
munsakad c7ef1ec
Merge branch 'department-portal-base' of https://github.com/BCStudent…
munsakad 25d9a9b
Reuse allocationManager.py in getAllocation.py
munsakad f5640b3
Fix missing LaborReleaseForm import in demo_data.py
munsakad 4c17019
Fix allocation card showing zeros for departments with only a draft a…
munsakad f3b43c6
removed unneccesary comments
munsakad 6ae3931
removed department information in main routes
munsakad 6f9486f
Merge branch 'department-portal-base' of https://github.com/BCStudent…
fritzj2 6d6997c
removed merge conflict fragment
fritzj2 ded0a5e
fixed broken icons in css
fritzj2 ba90482
added smaller logic for the allocation card
fritzj2 300b7b0
HTML now uses new variables
fritzj2 10fdda4
added the current semester
fritzj2 02a100d
fixed syntax when no value it given
fritzj2 9bb3197
removed out of scope change
fritzj2 fd86d2a
removed out of scope database issue
fritzj2 0b0324a
removed unused dateTime import
fritzj2 db6f90a
removed unused logic file
fritzj2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.