Ionic Conductivity Analysis - #132
Merged
Merged
Conversation
Bonds are not properly handled (Can tag atoms but not the bonds)
Otherwise we miss out on the length dependence
…meter names between datamodule and model
…es module and tests
awadell1
approved these changes
Oct 14, 2025
awadell1
left a comment
awadell1
left a comment
Member
There was a problem hiding this comment.
Nice! I assume updates figures are in the overleaf?
Would be good the sync at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mixture-splitsontomainso that it can be mergedComponentDataModuleclasses (stacked and dict) for ionic conductivity checkpoints