Run our own commands that Brigadier will not parse

[tastybento]

Fixes BentoBoxWorld/Border#179 — /oneblock border color green produced an unhandled CommandException out of a BentoBox scheduled task, and never changed the border colour.

Root cause

BrigadierCommandRegistrar puts a permission check in each sub-command literal's Brigadier requires predicate, so clients only see what they can use. Hiding a node that way is not passive:

• CommandNode#getRelevantNodes returns only the literal matching the typed token, so the greedy catch-all argument beside it is never considered;
• CommandDispatcher#parseNodes then silently skips that literal when canUse(source) is false.

So a player without [gamemode].border.color gets a parse that walks oneblock → border and dead-ends at color: Brigadier's INCORRECT_ARGUMENT at the cursor where color starts (exactly the ...ck border <--[HERE] in the report). The command line never reaches CompositeCommand, so instead of "you do not have permission" the player gets a red Brigadier error, and nothing runs.

Paper reports any CommandSyntaxException from Commands#finishParsing as an UnknownCommandEvent, not just genuinely unknown commands. That produced the rest of the report:

1. CommandMatcher re-attaches the tokens it could not match verbatim, so it suggested the very line that had just failed;
2. accepting that suggestion re-dispatched it through Player#performCommand inside a scheduled task with nothing catching what Bukkit throws — the unhandled CommandException in the report.

Changes

• DidYouMeanListener — a command line of ours that Brigadier refused to parse is dispatched through the command tree, which checks its own permissions and reports for itself; Brigadier's error is then dropped. Nothing has run at that point (Paper fails in its parse step, before execution), so there is no double execution.
• CommandsManager#resolveCommand — resolves a top level command from a typed first token: label, alias, or either in addon:label form.
• SuggestionsManager — never suggest a line identical to what was typed.
• DidYouMeanListener#acceptPending — log dispatch failures instead of letting them escape the scheduled task.

Testing

New UnparseableCommandTest reproduces the report end to end (permission-hidden sub-command → command reports for itself, nothing suggested back, nothing left pending, dispatch failures swallowed). Verified each test fails without the corresponding fix. Full suite green: 3391 tests, 0 failures.

Not addressed here

BrigadierCommandRegistrar#refreshTrees compares childCount(label) before and after the rebuild, but dispatcher.getRoot().getChild(label) returns Paper's wrapped (ApiMirrorRootNode) node while the merge lands on the NMS copy — so the count never changes and refreshClients() is never called. #3039's symptom is likely still present on a real server; the unit tests pass only because they use a plain RootCommandNode. Worth a follow-up.

🤖 Generated with Claude Code

https://claude.ai/code/session_01E6rYr6Z66LQz9XTbnbUupy

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
52.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud