Skip to content

Fixed renew and revoke used path style lease ids#224

Open
tv wants to merge 1 commit into
BetterCloud:masterfrom
tv:fix-renew-revoke-new-api
Open

Fixed renew and revoke used path style lease ids#224
tv wants to merge 1 commit into
BetterCloud:masterfrom
tv:fix-renew-revoke-new-api

Conversation

@tv

@tv tv commented Jun 5, 2020

Copy link
Copy Markdown

The current vault documents recommend having the lease_id in the body for easier policy management. So this PR does just that, moves lease_id to the body rather than having it in the url path.

@kurtdb

kurtdb commented Aug 25, 2020

Copy link
Copy Markdown

This solves an issue we are having: when trying to renew a lease, the current implementation of the vault (latest version) returns a http 403 when you put the leaseId in the request url: https://www.vaultproject.io/api-docs/system/leases#renew-lease

@igouss

igouss commented Oct 26, 2020

Copy link
Copy Markdown

Hi, can you please take a look at this patch. I have the same problem. Library is calling wrong URL.

@igouss

igouss commented Oct 26, 2020

Copy link
Copy Markdown

Meanwhile

            VaultResponse renew = vault.logical().write("sys/leases/renew", Map.of(
                    "lease_id", dataSource.getCredentials().getLeaseId(),
                    "interval", dataSource.getCredentials().getLeaseDuration()
            ));

@Sulion

Sulion commented Nov 6, 2020

Copy link
Copy Markdown

I think this lib is dead. ☠️ RIP.

@kurtdb

kurtdb commented Nov 6, 2020

Copy link
Copy Markdown

Maybe fork it and do some further development on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants