Repository navigation
correct seven red-letter ranges in the KJV - #201
Merged
Merged
Conversation
The KJV source marks three verses one character short, so their final full stop rendered black (Matthew 11:27, 13:17, Luke 10:22), and starts four ranges at the narrator's lead-in instead of at Jesus's words (Matthew 22:42, 24:2, Luke 7:40, 12:54). config/red_letter/kjv.yml lists the corrected red text for each and is applied by the same patch task as the RV1909 file. Lead-ins inside parables are left red: there Jesus is narrating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A visible glitch in the English red text, fixed with the same reviewed-file mechanism the Spanish uses.
What was wrong
The KJV source has two kinds of slip in its red-letter marking:
The fix
config/red_letter/kjv.ymllists the corrected red text for those seven verses.Bible::RedLetterPatchapplies it, andbible:import[kjv]now picks it up automatically on a fresh import.Eighteen other ranges begin with words like And he said unto him, but those are inside parables, where Jesus is the one narrating. They are correctly red and are left alone.
After deploy, from the Render shell:
It should print
Red-letter patch: marked 7 verses. The set of red verses does not change (still 2,066), so the Spanish file, the red chapter list and search are unaffected.Also here
Docs: the Spanish section name En Rojo is recorded as confirmed by the owner.