Repository navigation
search inside Jesus's words when the filter is on - #204
Merged
Merged
Conversation
verses.red_text holds a verse's red passages joined together, or NULL when it has none. The importer, the KJV mirror and the red-letter patch write it beside red_letter_ranges, and the migration fills it for verses already imported (4,132 locally, a few seconds). Verse.search_red_text searches it, so a match has to be inside his words.
With the filter ticked, keyword search now matches only inside the red text, and the highlighted snippet shows his words alone. Before, it kept any verse he speaks in, so a match could sit in the narration. The checkbox reads 'Search only the words of Jesus'. Concept search still filters by verse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the search filter mean what it says.
Before: ticking the box kept any verse Jesus speaks in, so a search for love could return a verse where loved is in the narration and his words say something else.
Now: keyword search matches only inside the red text, and the result snippet shows his words alone. The checkbox reads Search only the words of Jesus.
How
verses.red_text: a verse's red passages on their own, NULL when it has none.red_letter_ranges, so it stays in step with any future import or correction.db:prepareruns it on deploy; no manual step.Verse.search_red_textsearches the new column;SearchServiceuses it when the filter is on.Not changed
Concept search still filters by verse (a verse he speaks in), because its matching is by meaning across the whole verse, not by words.
Specs
Model specs for the red text and the new scope; importer, mirror and patch specs that it is written; service specs that a narration-only match is excluded and that the snippet is his words. The verse factory now fills
red_textthe way the importer does.Local check against the full data: love with the filter returns 20 results, all matching inside his words; publicans returns 6.