Repository navigation
fold the study form's two reading choices into one - #206
Merged
Merged
Conversation
The form had 'What this study reads' (whole Bible or Highlighted in Red) and, below it, 'Work through a list', where picking a list silently overrode the first. Now one control offers all of it: the whole Bible, Highlighted in Red chapter by chapter, a list, or a theme. Group#plan reads and writes focus and reading_list together, so the columns are unchanged. Also stops the translation name showing twice on a study's passage page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tidy-ups left over from #203.
One control instead of two. The study form had What this study reads (whole Bible or Highlighted in Red) and, under it, Work through a list, where picking a list quietly overrode the first choice. Now a single What this study reads menu offers everything:
The edit form shows the study's current choice and can change it. No schema change:
Group#planreads and writes the existingfocusandreading_listcolumns together.Translation name once. On a study's passage page the translation was named above the title and again beside the reference. It now appears only beside the reference.
Specs updated in the same commit: model specs for
plan, request specs for the form (new and edit) and the passage page, and the two system specs that fill in the form.