Repository navigation
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Stack note (2026-04-10): pushed Fresh local verification on
Keeping this PR as draft while the refreshed remote verify reruns. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/retrieval-contract.test.ts">
<violation number="1" location="test/retrieval-contract.test.ts:40">
P2: These assertions no longer verify the shell-escaping behavior their names describe.</violation>
</file>
<file name="src/lib/commands/integrations.ts">
<violation number="1" location="src/lib/commands/integrations.ts:248">
P1: Rollback for `snapshot.kind === "directory"` can silently delete existing directory contents. The code recursively removes the directory, then recreates it empty, so rollback is destructive instead of restorative.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Follow-up closeout note for the release-contract wave:
Adding this note so the old review remarks here have an explicit downstream resolution trail instead of relying on stack archaeology. |
a6d689e to
f4150c2
Compare
…2026-04-11 issue5 tail closeout blocker fixes
issue5 tail invalid cwd closure
issue5 close remaining runtime and extractor seams
…on-parity issue5 release gate isolation parity
issue5 init idempotency and force semantics
…sure issue5 keep session inspection read-only
issue5 runtime safety closure
…ediation issue5 runtime contract remediation
…oundaries issue5 claude and gemini host boundaries
…osure issue5 integrations install AGENTS boundary docs
issue5 wave3 contract closure
…sure issue5 release contract closure
Summary
cam doctor --jsonapp-server contract so environments withouttui/tui_app_serverno longer break reviewer smokeintegrations apply --host codex --jsonstaged-write failure handling so directory/launcher failures return structured rollback payloads instead of crashingIncluded
doctorsource/compiled/tarball contract coverage for nullablereadiness.appServerintegrations applystaged-write failure payloads:stackAction: "failed",failureStage: "staged-write",failureMessage, rollback metadata, and directory-aware rollback snapshotsCODEX_AUTO_MEMORY_DIST_CLI_PATHtestsCAM_PROJECT_ROOThelper behaviorExcluded
Verification
pnpm exec vitest run test/doctor-command.test.ts test/retrieval-contract.test.ts test/integrations-command.test.tspnpm buildpnpm test:dist-cli-smokepnpm test:tarball-install-smokepnpm test:docs-contractpnpm lintpnpm test:reviewer-smokeStack Notes
pr/issue5-08-route-truth-contractsf552d43backup/2026-04-09-wave2-start-pr8-20260409-211012backup/2026-04-09-wave2-start-remediation-20260409-211012backup-tag/...refsReview Order
a6d689eSummary by cubic
Hardens release-facing contracts across source, dist, and tarball CLIs: nullable app‑server in
doctor --json, structured staged‑write failure reports, and a portable retrieval workflow. Adds strict--cwdvalidation, read‑only session inspection, idempotentinit, and clarifies Claude/Gemini host andAGENTS.mdboundaries.Bug Fixes
doctor --json:readiness.appServeris nullable; compiled/tarball checks pass whentui/tui_app_serveris absent.--cwdflags fail closed on empty/whitespace/missing paths and require an existing directory; shell-safe quoting is used in emitted commands; hooks quotePROJECT_ROOT;cam rememberrejects empty text.session load/statusstay read-only on uninitialized projects; continuity recovery prefers pending records and treatsscope: bothas matching narrower requests.New Features
integrations apply --host codex --json: staged-write failures return a structured payload with stage, message, rollback status, and per-subaction attempts across source, dist, and tarball CLIs.doctor --jsonaddsrecommendedRouteand command hints; retrieval supports a packaged dist launcher viaCODEX_AUTO_MEMORY_DIST_CLI_PATHand safely appends--cwd.cam init: explicit, idempotent initialization with config shape validation and isolation from global config;integrations install --host codexinstalls the stack without updatingAGENTS.md; addedAGENTS.mdand docs clarifying Claude/Gemini remain manual-only snippet hosts.Written for commit 13f9d7f. Summary will update on new commits.