fix: tolerate log handlers without baseFilename (pytest compat) - #142
Open
afatihakpolat wants to merge 1 commit into
Open
fix: tolerate log handlers without baseFilename (pytest compat)#142afatihakpolat wants to merge 1 commit into
afatihakpolat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
Bug
BusKill.init crashed under pytest with AttributeError: '_LiveLoggingNullHandler' object has no attribute 'baseFilename' at src/packages/buskill/init.py:227, because pytest replaces root handlers with its own (no baseFilename).
Fix
One line on dev: getattr fallback so handlers without baseFilename yield None instead of crash. Dev already guarded empty handlers list but not missing attribute; this strengthens it. Normal FileHandler path unchanged (real path preserved).
Before: logger.root.handlers[0].baseFilename if handlers else None -> AttributeError under pytest
After: getattr(handlers[0], 'baseFilename', None) if handlers else None -> None under pytest, real path normally
Tests
Files