fix: dynamic git dir lookup instead of hardcoded dev path - #143
Open
afatihakpolat wants to merge 1 commit into
Open
fix: dynamic git dir lookup instead of hardcoded dev path#143afatihakpolat wants to merge 1 commit into
afatihakpolat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111
Bug
upgrade() used --git-dir=/home/user/sandbox/buskill-app/.git when SOURCE_DATE_EPOCH empty. Fails on any other machine with fatal: not a git repository, then int(b'') ValueError / hang (no timeout).
Fix
Dynamic .git discovery: BUSKILL_GIT_DIR override (dir or root) -> upward search from file (covers worktrees). List-form subprocess, timeout 10, returncode/stdout guard, try/except graceful continue. No shell=True, no new imports.
Tests
Files