Broad, sweeping improvements#37
Open
sarahsturgeon wants to merge 56 commits into
Open
Conversation
sarahsturgeon
marked this pull request as ready for review
June 19, 2023 00:32
2 tasks
thecraftianman
approved these changes
Jan 3, 2026
wrefgtzweve
approved these changes
Jan 3, 2026
(Repurposed the retry convar for unsuccessful reqs - may not even need it to be a convar idk
Works better + doesn't depend on pac3
Updates it to the latest version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ballooned up with a few different fixes and enhancements.
Currently, it:
unsuccessfulfailuresRangeheader (supported in: Add Range header support gm_express_service#9) to download in chunksexpress.Sendraw string data, skipping the serialization stepexpress.Seedwhich allows you to seed data before you need to send itThis will probably be the second-to-last major change before I put more time into a V2 rewrite with the lessons learned on our first run through.
Todo:
Do you want to use this?
I believe it's currently stable enough to run.
It should fix a lot of the instability and odd behavior seen from Express's main branch.
You need to:
feature/include-http-failures-in-retries)express_domainconvar tostg.gmod.express