Repository navigation
dlt: Prevent symlink following in offline log storage - Issue #901 - #922
Open
KaramSathishKumar wants to merge 1 commit into
Open
KaramSathishKumar wants to merge 1 commit into
KaramSathishKumar wants to merge 1 commit into
Conversation
Author
|
Without fix (1620f85): Replaced dlt file with a symlink to a protected test file. After triggering offline logging, DLT data was written through the symlink and the target file hash changed. Issue reproduced. With fix (e451888): Repeated the same test. The protected target remained unchanged and the hash stayed the same. Issue not reproduced with the fix. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #901
This change prevents offline log storage from following symbolic links when opening log output files.
The change protects log file operations against symlink-based redirection while preserving the existing behavior for regular files.