Repository navigation
fix: reintroduce extended attributes support in jsonschema exporter - #563
Conversation
sebroy-oti
changed the title
Signed-off-by: Sébastien Roy <sroy@orthogone.com>
Signed-off-by: Sébastien Roy <sroy@orthogone.com>
1877684 to
5d902ab
Compare
sebroy-oti
changed the title
| if extend_all_attributes: | ||
| add_x_attributes(schema, node) | ||
| for field in vss_data.get_extra_attributes(): | ||
| schema[field] = getattr(vss_data, field) |
There was a problem hiding this comment.
Personally I would group them in e.g a x-extra object to make it explicit that those properties are not related to a JSON schema and to avoid possible conflicts.
There was a problem hiding this comment.
Added. I originally left it as it was in 5.0 to avoid breaking changes, but I agree it's better to group those custom fields separately.
Signed-off-by: Sébastien Roy <sroy@orthogone.com>
|
We are preparing the 6.1 release, and are currently at the state with release candidates. Do you see this as a fix that better should be included also in 6.1 (and not just the release following 6.1) |
We recently bumped vss-tools to 6.0 in our solution and had to create a fork that includes this fix as we require custom attributes to be accessible in the generated JSON Schema. In our case, it would be preferable if this fix made it into 6.1 so we could drop our vss-tools fork and use upstream 6.1. However, it's not essential it makes it to 6.1, as we can continue using a fork until the release following 6.1. |
|
Thanks @sebroy-oti - I think there will be no problem to include it. I will take a look at it and possibly then create a new release candidate later today or early next week including it |
…563) * Reintroduce extra attributes support in jsonschema Signed-off-by: Sébastien Roy <sroy@orthogone.com> * Fix trailing whitespaces Signed-off-by: Sébastien Roy <sroy@orthogone.com> * Group extra attributes in an x-extra object.t Signed-off-by: Sébastien Roy <sroy@orthogone.com> --------- Signed-off-by: Sébastien Roy <sroy@orthogone.com> Co-authored-by: Sébastien Roy <sroy@orthogone.com>
|
Merged and cherry-picked to 6.1 branch. I created a new release candidate for 6.1 vss-tools (but have not yet created a new vss release candidate referencing it). How to install the release candidate:
|
…OVESA#563) * Reintroduce extra attributes support in jsonschema Signed-off-by: Sébastien Roy <sroy@orthogone.com> * Fix trailing whitespaces Signed-off-by: Sébastien Roy <sroy@orthogone.com> * Group extra attributes in an x-extra object.t Signed-off-by: Sébastien Roy <sroy@orthogone.com> --------- Signed-off-by: Sébastien Roy <sroy@orthogone.com> Co-authored-by: Sébastien Roy <sroy@orthogone.com>
3 participants
Uh oh!
There was an error while loading. Please reload this page.