Skip to content

Task 562/fix handling of duplicate signals - #566

Merged
erikbosch merged 2 commits into
COVESA:masterfrom
Kostadin-Ivanov:task-562/fix-handling-of-duplicate-signals
Sep 29, 2026
Merged

erikbosch merged 2 commits into
COVESA:masterfrom
Kostadin-Ivanov:task-562/fix-handling-of-duplicate-signals

Conversation

@Kostadin-Ivanov

Copy link
Copy Markdown
Contributor

Updates done:

  1. Fix handling of top_vss_tree_unique_node_names by setting more stable node key handling for better identification of repetitive nodes
  2. Update handling of ttl_name so it can be used better for nodes property name definitions
  3. Update handling of PREFERRED_NAME so to preserve node name casing and parent name casing, if needed, when human readable PREFERRED_NAME value is defined for the corresponding node
  4. Update SAMM unit for Celsius and add a new SAMM unit for the VSS "ms" unit
  5. Update string_helper to handle better CamelCase strings and split those for the more "human friendly" "split camel case strings"
  6. Replace some hardcoded strings with corresponding SammCConcepts and SammConcepts constants

@Kostadin-Ivanov
Kostadin-Ivanov force-pushed the task-562/fix-handling-of-duplicate-signals branch 4 times, most recently from aca982c to eb0e4e1 Compare September 21, 2026 14:26
@erikbosch

Copy link
Copy Markdown
Collaborator

MoM:

  • Please review

Signed-off-by: Kostadin Ivanov <kostadin.ivanov@bosch.com>
Signed-off-by: Kostadin Ivanov <kostadin.ivanov@bosch.com>
@Kostadin-Ivanov
Kostadin-Ivanov force-pushed the task-562/fix-handling-of-duplicate-signals branch from eb0e4e1 to bf3c801 Compare September 23, 2026 14:29
Comment thread src/vss_tools/exporters/samm/helpers/data_types_and_units.py

@erikbosch erikbosch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marnova

marnova commented Sep 29, 2026

Copy link
Copy Markdown

LGTM too :)

@erikbosch

Copy link
Copy Markdown
Collaborator

MoM:

  • D - Duplication of units also appeared some times ago
  • E - unrelated
  • Ok to merge

@erikbosch
erikbosch merged commit 5e21856 into COVESA:master Sep 29, 2026
5 checks passed
@Kostadin-Ivanov
Kostadin-Ivanov deleted the task-562/fix-handling-of-duplicate-signals branch September 30, 2026 09:12
ansgarradermacher pushed a commit to ansgarradermacher/vss-tools that referenced this pull request Oct 7, 2026
* Fix handling of duplicate handling. Update string helper functions.

Signed-off-by: Kostadin Ivanov <kostadin.ivanov@bosch.com>

* Update handling of PREFERRED_NAME

Signed-off-by: Kostadin Ivanov <kostadin.ivanov@bosch.com>

---------

Signed-off-by: Kostadin Ivanov <kostadin.ivanov@bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants