Firefly-2039: Fixed: Incorrect flag mask shown for a pixel with no flags#1975
Open
robyww wants to merge 1 commit into
Open
Firefly-2039: Fixed: Incorrect flag mask shown for a pixel with no flags#1975robyww wants to merge 1 commit into
robyww wants to merge 1 commit into
Conversation
tgoldina
requested changes
Jul 2, 2026
tgoldina
left a comment
tgoldina
left a comment
Contributor
There was a problem hiding this comment.
Previously, the lower-right pixel was always shaded for every mask plane; now it is never shaded for any mask plane.
This suggests that the bug lies elsewhere in the shader. I have attached lrset_5x5.fits to the ticket; it now has flags set for every pixel. The lower-right pixel, which the mouse pointer is hovering over, is not shaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2039: Fixed: Incorrect flag mask shown for a pixel with no flags
Test