Feat/inflight request coalescing#401
Open
Priyanshu1-62 wants to merge 3 commits into
Open
Conversation
| let cleanedText = rawText | ||
| .replace(/^\s*```json\s*/i, "") | ||
| .replace(/^\s*```\s*/i, "") | ||
| .replace(/(\s*```\s*)+$/i, "") |
Contributor
|
@Priyanshu1-62 please take a look on github ai suggestion. |
Author
|
Hi @KaranUnique ,
Let me know how you would like to proceed. |
Contributor
|
@Priyanshu1-62 However, codeQL is reporting this as a new alert in code introduced by this PR, specifically on the newly added regex at line 102. Please update the regex to resolve the ReDoS warning before we proceed with the merge |
Author
|
Hi @KaranUnique , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Description
Related Issue
Summary
Implementation Details
Type of Change
How Has This Been Tested?
npm run testshows no new failed test due to changes made in this PR.Checklist
Additional Details