fix: prevent MAX_SESSIONS race condition during concurrent session creation#428
Merged
KaranUnique merged 1 commit intoJul 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #372.
This PR resolves a race condition in
createSessionthat allowed concurrent requests to bypass theMAX_SESSIONSlimit.Previously, the controller performed:
countDocuments({ user })MAX_SESSIONSBecause these operations were executed separately, multiple concurrent requests could observe the same session count before any insert completed, allowing more than
MAX_SESSIONSsessions to be created.Changes
Why this Fix
Executing both operations within a transaction removes the race window between checking the number of sessions and creating a new one.
Under concurrent requests:
MAX_SESSIONS.Testing
MAX_SESSIONS - 1sessions.MAX_SESSIONS.Impact
This change is backward compatible and only strengthens enforcement of the existing session limit under concurrent requests.