fix: make session deletion transactional#429
Open
hariom888 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #373.
This PR makes
deleteSessionatomic by wrapping the deletion of both the session and its associated questions inside a MongoDB transaction.Previously,
Question.deleteMany()andSession.deleteOne()were executed as two independent operations. If a failure occurred after deleting the questions but before deleting the session, the database could be left in an inconsistent state where the session still existed but its associated questions had already been removed.Changes
Why this Fix
Using a MongoDB transaction guarantees atomicity across both collections.
If every operation succeeds:
If any operation fails:
This prevents partial deletes and keeps the database in a consistent state.
Testing
Impact
This change is backward compatible and improves data consistency by preventing partial deletion scenarios and orphaned records during session deletion.