Repository navigation
[Fusion] Avoid list wrappers for pocketed error snapshots - #10597
Closed
tobias-tengler wants to merge 1 commit into
Closed
tobias-tengler wants to merge 1 commit into
tobias-tengler wants to merge 1 commit into
Conversation
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 59.0% (311445/527757 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing pocketed errors creates a list wrapper even though completion callers only enumerate the eager snapshot.
This PR returns a fresh eager array directly from the snapshot helper.
Entry order, shared path/error references and snapshot isolation during callbacks are preserved; focused tests pass on .NET 10 and .NET 11.
Release .NET 10 measurements of snapshot capture plus a common indexed reference consumer against pinned
main15888585e1show stable three-error allocation reduction from 104 to 72 B (32 B, 30.77%). The accepted elapsed costs are 12.71% (3.88 ns) for three errors and 6.61% (1.11 ns) for one error; no elapsed improvement is claimed. One-error allocation readings were 72/72→0/40 B across repetitions, so the displayed 72→20 B arithmetic mean is uncertain and supports no allocation claim. The empty guard is a control.mainmainmain