Repository navigation
[Fusion] Fix repeated Kafka cursor topic grouping - #10599
Closed
tobias-tengler wants to merge 1 commit into
Closed
tobias-tengler wants to merge 1 commit into
tobias-tengler wants to merge 1 commit into
Conversation
Contributor
Patch coverage100.0% of changed lines covered (7/7)
Project coverage: 59.0% (311450/527761 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a Kafka event with a composite cursor groups the same partition frontier by topic once to calculate the cursor size and again to format the cursor.
This PR reuses the groups created during sizing when formatting that event. Standalone formatting, cached single-partition and no-cursor paths, cursor bytes, rollback and delivery behavior remain unchanged.
All 41 focused tests pass on .NET 10 and 11 with Release/style checks.
Against pinned
main15888585e14566bc1fd3e6ef50cac5ff34f47785, the completeCreateMessagefactory with full body/cursor consumption and owner disposal improves three-partition CPU-bound elapsed by 13.53%; two topics improve 9.70%, below the gate. Cached and no-cursor controls cost +1.77 ns (1.82%) and +0.55 ns (1.86%). The table uses arithmetic means of two launches per version. All allocation rows are unreliable, with no allocation claim: native pairs main → PR are cached 64/0 → 64/64 B, two topics 0/560 → 344/344 B, no cursor 0/64 → 64/0 B, and three partitions 592/592 → 376/317 B; adverse arithmetic means remain visible. Scope is event construction, consumption and disposal.mainmainmainmain