Added attach jacoco report#2452
Merged
Merged
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
marked this pull request as ready for review
June 16, 2025 17:26
Contributor
There was a problem hiding this comment.
Other comments (5)
-
jacoco-report-generator.mjs (243-243)
The GitHub API authentication is using the deprecated `token` format. GitHub recommends using the Bearer authentication scheme instead.
'Authorization': `Bearer ${token}`, -
jacoco-report-generator.mjs (293-293)
Same authentication issue here - use Bearer format instead of token.
'Authorization': `Bearer ${token}`, - .github/workflows/analysis.yml (103-111) Consider removing the debug commands (`pwd` and `ls`) before merging this PR. These commands are typically only used during development.
-
jacoco-report-generator.mjs (335-335)
The help text references an incorrect filename ('jacoco-report.mjs') which doesn't match the actual filename ('jacoco-report-generator.mjs').
console.log(' node jacoco-report-generator.mjs <input-csv> <output-md> [--title "Report Title"]'); -
jacoco-report-generator.mjs (339-339)
Same filename issue in the GitHub PR comment usage example.
console.log(' GITHUB_TOKEN=your_token node jacoco-report-generator.mjs <input-csv> <output-md> \\');
💡 To request another review, post a new comment with "/windsurf-review".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Closes #2439
Checklist
Delete items not relevant to your PR: