Repository navigation
The toolbar above an open message acts on that message - #417
Merged
Merged
Conversation
With conversation view off, marking a message unread from the list -- the hover button, the right-click menu -- marked that message. Opening it and pressing Mark as unread in the toolbar above it marked every message in its thread, and so did Move to, Report spam and Delete. The setting already reaches all the way into the reading pane: the list draws one row per message, and `visibleMessages` narrows the pane to the one opened. The toolbar was half converted. Its labels were right -- Mark as unread against Mark as read, the star, the labels shown -- all of those read `messages`, which is the narrowed set. Only `rowIds`, the one thing actually handed to the action, still read `thread.emailIds`. So the button said one message and did the whole conversation. `rowIds` is now the same question `visibleMessages` answers for the pane, asked of the same ids, with the same fallback: an id that names nothing in the thread -- a link from somebody with conversation view on, a stale `m` in the URL -- shows the conversation, so the toolbar takes the conversation. Conversation view on is unchanged: nothing is singled out, so the whole thread comes back as before. No new strings.
jcoffey-dev
force-pushed
the
fix/toolbar-acts-on-the-open-message
branch
from
September 20, 2026 21:47
fbe3072 to
e0b6f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #414.
With conversation view off, marking a message unread from the list — the hover button, the right-click menu — marked that message. Opening it and pressing Mark as unread in the toolbar above it marked every message in its thread, and so did Move to, Report spam and Delete.
The setting already reaches all the way into the reading pane: the list draws one row per message, and
visibleMessagesnarrows the pane to the one opened. The toolbar was half converted. Its labels were right — Mark as unread against Mark as read, the star, the labels shown — all of those readmessages, which is the narrowed set. OnlyrowIds, the one thing actually handed to the action, still readthread.emailIds. So the button said one message and did the whole conversation.rowIdsis now the same questionvisibleMessagesanswers for the pane, asked of the same ids, with the same fallback: an id that names nothing in the thread — a link from somebody with conversation view on, a stalemin the URL — shows the conversation, so the toolbar takes the conversation. Conversation view on is unchanged: nothing is singled out, so the whole thread comes back as before.Four tests render the toolbar and press the buttons: one open message for unread, and for move/spam/delete; the whole thread when none is singled out; and the stale-id fallback. The first two fail without the change.
No new strings.