Skip to content

[codex] fix debug wait server readiness status#268

Draft
thatssomoneybaby wants to merge 1 commit into
CortexLM:mainfrom
thatssomoneybaby:fix-debug-wait-server-ready-404
Draft

[codex] fix debug wait server readiness status#268
thatssomoneybaby wants to merge 1 commit into
CortexLM:mainfrom
thatssomoneybaby:fix-debug-wait-server-ready-404

Conversation

@thatssomoneybaby
Copy link
Copy Markdown

Summary

  • require successful HTTP responses for cortex debug wait --server-ready
  • add a regression test covering a 404 readiness endpoint

Root Cause

The wait handler treated all client-error responses as readiness success, so a missing readiness endpoint could make --server-ready exit successfully.

Validation

  • git diff --check
  • cargo fmt --check --package cortex-cli
  • cargo check -p cortex-cli
  • cargo test -p cortex-cli --test debug_wait -- --nocapture

Related bounty issue: PlatformNetwork/bounty-challenge#46738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant