fix: avoid utf8 panic in web fetch truncation#276
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PlatformNetwork/bounty-challenge#53271.\n\nWhat changed:\n- Replaced byte-index truncation in app-server web fetch output with character-based truncation.\n- Added a regression test that places a multi-byte character across the old 100,000-byte boundary.\n\nVerification:\n- cargo test -p cortex-app-server truncates_fetch_output_on_utf8_boundary_without_panic -- --nocapture\n- cargo test -p cortex-app-server --lib -- --skip tools::shell::tests::test_execute_shell\n- cargo check -p cortex-app-server\n- cargo fmt --check --package cortex-app-server\n- git diff --check\n\nNote: the skipped app-server lib test is the existing Windows-only shell test that expects echo as an executable.