Skip to content

fix(exec): resolve relative prompt files against --cwd#302

Open
694410194 wants to merge 2 commits into
CortexLM:mainfrom
694410194:codex/exec-file-respects-cwd
Open

fix(exec): resolve relative prompt files against --cwd#302
694410194 wants to merge 2 commits into
CortexLM:mainfrom
694410194:codex/exec-file-respects-cwd

Conversation

@694410194
Copy link
Copy Markdown

Summary

  • resolve relative --file prompt paths against --cwd when a working directory is provided
  • keep absolute prompt file paths unchanged
  • add focused path-resolution unit coverage for relative, absolute, and no---cwd cases

Verification

  • git diff --check
  • static check that build_prompt now reads from resolve_prompt_file_path(file_path, self.cwd.as_deref())
  • added focused unit tests for relative path resolution behavior
  • rustc --version (not available in this environment, so cargo-based checks could not be run here)

Fixes #53169
/claim #53169

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant