Skip to content

fix(update): stop repeating the same startup update banner#305

Open
694410194 wants to merge 1 commit into
CortexLM:mainfrom
694410194:codex/suppress-repeat-update-banner
Open

fix(update): stop repeating the same startup update banner#305
694410194 wants to merge 1 commit into
CortexLM:mainfrom
694410194:codex/suppress-repeat-update-banner

Conversation

@694410194
Copy link
Copy Markdown

Summary

  • persist last_notified_version when background startup checks surface an available update
  • suppress repeat notifications for the same version in both the CLI background notifier and the TUI startup banner until a newer release appears
  • add focused cortex-update coverage for notification tracking and persistence

Fixes PlatformNetwork/bounty-challenge#53190
/claim #53190

Verification

  • cargo test --manifest-path /tmp/cortex-bounty/Cargo.toml -p cortex-update
  • cargo check --manifest-path /tmp/cortex-bounty/Cargo.toml -p cortex-cli -p cortex-tui
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Update banner can reappear on every launch because last_notified_version is never used

1 participant