Skip to content

Refactor parseArtSci function#1725

Open
r-weng wants to merge 5 commits into
Courseography:masterfrom
r-weng:refactor-parseArtSci-function
Open

Refactor parseArtSci function#1725
r-weng wants to merge 5 commits into
Courseography:masterfrom
r-weng:refactor-parseArtSci-function

Conversation

@r-weng

@r-weng r-weng commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

This pull request refactors the parseArtSci function in app/WebParsing/ArtSciParser.hs by introducing a new function, parseDepartmentList, to handle parsing of department lists. Additionally, parseDepartmentList now ignores department pages with no courses, duplicate courses, and program areas belonging to a college.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Jun 7, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 48

Coverage decreased (-0.1%) to 58.532%

Details

  • Coverage decreased (-0.1%) from the base build.
  • Patch coverage: 12 uncovered changes across 1 file (0 of 12 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/WebParsing/ArtSciParser.hs 12 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3953
Covered Lines: 2375
Line Coverage: 60.08%
Relevant Branches: 964
Covered Branches: 503
Branch Coverage: 52.18%
Branches in Coverage %: Yes
Coverage Strength: 164.22 hits per line

💛 - Coveralls

@r-weng r-weng requested a review from david-yz-liu June 7, 2026 16:37

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r-weng This is good, but please write tests for this new function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants