Conversation
BanjoR
marked this pull request as ready for review
August 17, 2026 09:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authoritative references
Bounded scope
This refresh changes exactly five source files:
CommandDistributor.cpp/CommandDistributor.h: add a client-safe current/fault broadcast using the existingCommandDistributorpath.DCCEXParser.cpp: add opt-in<JI 1>and<JI 0>controls while preserving the existing plain<JI>query.TrackManager.cpp/TrackManager.h: add disabled-by-default, 100 ms-throttled telemetry from existing current and overload/fault state.When enabled, events use
<jI TRACK CURRENT_MA FAULT>with zero-based track number, measured milliamps, and0/1fault state. The implementation is opt-in and broadcasts through the client-safe distributor rather than retaining the parser's transient Wi-Fi/Ethernet stream.Explicit exclusions:
<JI>response.<A>or<a>protocol command and no internal RMS/history-buffer design.Validation
All results below refer to head commit
37cda773.git diff --check.<JI>backward compatibility,<JI 1>/<JI 0>gating,<jI>event formatting, default-disabled state, 100 ms throttling, current/fault sources, and safe broadcast routing.mega2560,ESP32,Nucleo-F411RE,Nucleo-F446RE, andNucleo-F429ZI.Hardware validation
Not run—no hardware available.
Maintainer bench criteria:
<JI 1>, and verify nominal approximately-100-ms<jI TRACK CURRENT_MA 0>events for every active track, with the reported milliamps matching an independent meter or known load within the board's expected accuracy.<jI TRACK CURRENT_MA 1>and enters the existing overload state; clear the condition and verify recovery behavior.<JI 0>and verify asynchronous events stop, while a plain<JI>still returns the established one-shot current response.This pull request is ready for maintainer review; hardware validation remains outstanding; local firmware compilation is complete.
Current exact-head CI status
N/A — No BanjoR fork Actions run exists for exact head
37cda773ff695da09f23ffa8e551e90650266b57; no hosted code-test result is claimed. Local validation above is the available evidence.