Rename the authz surface to "exchange" (siwe + exchange) - #13
Merged
Merged
Conversation
The two surfaces are now named for the actions they perform: /siwe (sign-in) and /exchange. This replaces the lingering "token exchange" package/identifier verbiage and the brief interim "sacd" naming, and it finally aligns the internal name with the shipped gRPC TokenExchangeService. Surface (renamed everywhere — packages, URL, env, secrets, docs): - internal/tokenexchange -> internal/exchange (all import paths) - public route /permissions had become /sacd; now /exchange, which drives the issuer (iss == the URL the discovery doc is served from): EXCHANGE_ISSUER=https://dauth.dimo.zone/exchange - env vars -> EXCHANGE_ISSUER / EXCHANGE_SIGNING_KEY_* - AWS secret path -> <ns>/exchange/signing_key_1 - ExchangeController, exchange*.go, swagger basePath, README, charts, docker, run-local, local keyfile SACD-the-domain stays SACD (it's the on-chain access-control primitive, not the surface): contracts/sacd, sacdproxy, models.SACDData, SACDInterface, autheval's sacd* maps, GetValidSacdDoc, TypeSACD, CONTRACT_ADDRESS_SACD, and every "on-chain SACD access check". The `permissions` claim and the "permission token" artifact name are part of the token contract and are likewise unchanged. Kept frozen: the gRPC contract consumers depend on (TokenExchangeService, pkg/grpc/token-exchange-api.*, TokenExchangeServer, ServiceName) — it already carries the "exchange" term. Build, vet, gofmt, full test suite, and helm lint (dev + prod) all pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDG5nQUwFwLsJmVeAorpPq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Names the two surfaces for the actions they perform —
/siwe(sign-in) and/exchange— replacing the lingering "token exchange" package/identifier verbiage. This also finally aligns the internal name with the shipped gRPCTokenExchangeService.The one distinction that drives the whole diff
There were two
sacds doing different jobs, and they go opposite directions:exchange= the surface → renamed everywhereSACD= the on-chain access-control primitive → stays exactly as-isA blanket find/replace would have corrupted real contract code; this PR carefully preserves the domain term.
Surface →
exchange(packages, URL, env, secrets, docs)internal/tokenexchange/→internal/exchange/(all import paths)/exchange, which drives the issuer (iss == the URL the discovery doc is served from):EXCHANGE_ISSUER=https://dauth.dimo.zone/exchangeEXCHANGE_ISSUER/EXCHANGE_SIGNING_KEY_*<ns>/exchange/signing_key_1ExchangeController,exchange*.go, swagger basePath, README, charts, dockerfile, run-local, local keyfileSACD-the-domain — unchanged
contracts/sacd,sacdproxy,models.SACDData,SACDInterface,autheval'ssacd*maps,GetValidSacdDoc,TypeSACD,CONTRACT_ADDRESS_SACD, and every "on-chain SACD access check". Thepermissionsclaim and the "permission token" artifact name are part of the token contract and are likewise untouched.Kept frozen
The gRPC contract consumers depend on —
TokenExchangeService,pkg/grpc/token-exchange-api.*,TokenExchangeServer,ServiceName— which already carries the "exchange" term.Deploy follow-ups (flag-day, consumer-owned)
…/exchange/keysand isshttps://dauth.dimo.zone/exchange(telemetry/dq/fetch auth0 validators pin that iss).<ns>/exchange/signing_key_1.Verification
Build, vet, gofmt, full test suite, and helm lint (dev + prod) all pass.
🤖 Generated with Claude Code