fix(materializer): run the rollup cardinality probe every refresh under mode on - #64
Merged
Conversation
…er mode on The probe rode the shadow diff, which mode on no longer runs — so the standing corruption-stays-gone check silently degraded to boot-only. Best-effort per refresh now, matching what dq#63 claimed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cardinality probe (
dq_materializer_daily_rollup_table_rows— the standing proof the fold-era duplicate corruption stays gone) rode the shadow diff, which modeonno longer runs, so since the flip it fired at boot only and the gauges froze at pod start. Now best-effort at the end of every refresh, which is what #63's description claimed it did. One line + comment; suite and lint green.Refs #55, #63.
🤖 Generated with Claude Code