Correctly set glConfig.reflectionMappingAvailable#1978
Merged
Conversation
glConfig.reflectionMappingAvailable was set after shaders are loaded, so gl_reflectionShader was not loaded when it should be. Set it in EnableAvailableFeatures(). Also it could only be set to true; if you turned off the cvar the next map change would not set it to false. Fixes the bug that r_showCubeProbes causes a crash (due to null gl_reflectionShader) if reflection mapping was not enabled in the previous renderer load.
If a required feature of normal/deluxe/specular mapping was disabled for a reason other than the cvar, glConfig.reflectionMappingAvailable must be set to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash with
r_showCubeProbes.