a few improvements and todo completions#1220
Open
TheBearodactyl wants to merge 6 commits into
Open
Conversation
TheBearodactyl
force-pushed
the
master
branch
from
8d37d2b to
b334237
Compare
TheBearodactyl
changed the title
TheBearodactyl
force-pushed
the
master
branch
from
b334237 to
80ded77
Compare
Author
|
woah did not mean to do that 💀 |
Author
|
one sec |
TheBearodactyl
force-pushed
the
master
branch
from
80ded77 to
872b943
Compare
Author
|
fixed |
Author
welp, pretty sure the CI fails weren't me, so that's good |
BradLewis
reviewed
Dec 14, 2025
Collaborator
Actually since this working correctly on master I believe this is indeed from your changes. I have the same test failing on your branch when running locally. |
Author
|
oh, huh. |
Collaborator
|
It's actually failing on windows as well, but that doesn't fail the build 😅 |
Author
|
HUH |
Author
|
ok i have no idea what's going on because i haven't made any changes to the hover implementation and nothing i do fixes the test |
BradLewis
reviewed
Dec 15, 2025
TheBearodactyl
force-pushed
the
master
branch
from
1dfddd2 to
90f0b85
Compare
BradLewis
reviewed
Dec 15, 2025
| [dynamic]^ast.Comment_Group, | ||
| [dynamic]^ast.Comment_Group, | ||
| ) { | ||
| index := build_comment_index(file) |
Collaborator
There was a problem hiding this comment.
Same comment applies with this index as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ast.odin)completion.odin)should_resolve_all_proc_overload_possibilities(analysis.odin)memory_index.odin)generics.odin)