Repository navigation
test: apply BlockingPortal filter at pytest collection (#1871) - #1917
Merged
Merged
Conversation
Warm starlette.testclient in pytest_configure under the exact DeprecationWarning ignore, and re-apply it in pytest_collection. addopts -W error stays; item marks remain for runtest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeprecationWarningfromimport starlette.testclient(anyio.abc.BlockingPortal) still failed Dependabot deps(uv): bump the uv-minor-patch group across 1 directory with 29 updates #1871 after test: ignore starlette BlockingPortal deprecation under -W error (#1871) #1916: per-itemfilterwarningsmarks run after collection.pytest_configurewarmsstarlette.testclientonce underwarnings.catch_warnings()with the exact message ignore.pytest_collection(cmdline-W errorfrom CI/quick-test still wins over ini). Per-item marks kept for runtest.addopts = "-v -W error"unchanged. Notignore::DeprecationWarning, not:anyio.abcmodule-scope.Test plan
anyio 4.15.1,starlette 1.6.0):pytest tests/test_api_key.py --collect-only -W error./scripts/quick-test.sh --path tests/test_pytest_blockingportal_filterwarnings.pyDoes not include
uv.lockbumps — rebase #1871 after this lands.