Repository navigation
docs: REST pass_from_env allowlist, Microsoft login host, RC extras - #2041
Merged
FabioLeitao merged 1 commit intoOct 12, 2026
Merged
Conversation
Document env-secret egress for REST *_from_env (explicit allowed_hosts after loader copy into pass) versus SQL/share DEMO_DB_PASSWORD prefixes, Power BI/Dataverse login.microsoftonline.com-only token POSTs, and completão rc_bench_extras missing_optional_dependency vs unreachable.
FabioLeitao
force-pushed
the
cursor/technical-documentation-maintenance-4a81
branch
from
October 12, 2026 02:46
719caab to
e437fd0
Compare
FabioLeitao
deleted the
cursor/technical-documentation-maintenance-4a81
branch
October 12, 2026 02:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align operator docs with already-shipped behavior: REST env-secret
pass_from_envstill requires explicitallowed_hostsafter the loader copies intopass; Power BI/Dataverse token POST is limited tohttps://login.microsoftonline.com; completãorc_bench_extrasreportsmissing_optional_dependency(notunreachable) when optional NoSQL extras are absent. EN + pt-BR pairs only; no product code change.Type of change
Issue linking (required)
Closes #NNNNor documentsNo issue closed:aboveDocs added/updated
docs/USAGE.md+docs/USAGE.pt_BR.md— REST*_from_envprefixes vs SQL/shareDEMO_DB_PASSWORD;pass_from_envYAML example; explicitallowed_hostsafter loader copy; Microsoft login host constraintdocs/TECH_GUIDE.md+docs/TECH_GUIDE.pt_BR.md— env-secret egress forpass_from_env/password_from_env/user_from_env; Power BI/Dataverse token POST hostdocs/TROUBLESHOOTING.md+docs/TROUBLESHOOTING.pt_BR.md— security(HIGH): PowerBI connector POSTs client_secret_from_env to any public token_url, same gap #1977 fixed for REST #2007 Microsoft login host rowdocs/TROUBLESHOOTING_CREDENTIALS_AND_AUTH.md+ pt-BR pair — REST*_from_envstill needsallowed_hosts; security(HIGH): PowerBI connector POSTs client_secret_from_env to any public token_url, same gap #1977 fixed for REST #2007 sovereign-cloud failuredocs/ops/LAB_COMPLETAO_RUNBOOK.md+ pt-BR —rc_bench_extraslist/verify; RC v3 mysql/nosql/postgres/shares; missing nosql =missing_optional_dependencynotunreachableCodepaths covered
connectors/rest_connector.py_target_loads_secrets_from_env(pass_from_env / password_from_env / user_from_env after copy into pass; prefixesAPI_/REST_API_/DATA_BOAR_)connectors/microsoft_identity.pylogin host allowlist (login.microsoftonline.comonly, security(HIGH): PowerBI connector POSTs client_secret_from_env to any public token_url, same gap #1977 fixed for REST #2007)scripts/rc_bench_extras.py+scripts/lab-completao-host-smoke.sh(optional extras;missing_optional_dependencyvsunreachable)Knowledge gaps addressed
pass_from_envstill requires explicitallowed_hostseven after the env loader copies the secret intopass*_from_envprefixes areAPI_/REST_API_/DATA_BOAR_only; SQL/shareDEMO_DB_PASSWORDremains valid for those targets — do not apply REST prefixes to DB YAMLhttps://login.microsoftonline.com; sovereign clouds fail security(HIGH): PowerBI connector POSTs client_secret_from_env to any public token_url, same gap #1977 fixed for REST #2007missing_optional_dependency, not a networkunreachable🧱 Checklist de Integridade
pyteston docs locale/external-link/coauthorship guards (239 passed). Fullcheck-all/ Rust clippy not required for this docs-only slice.Note
Low Risk
Documentation-only updates across paired EN/pt-BR guides; no runtime, auth, or connector behavior changes in this PR.
Overview
This PR updates operator documentation only (EN + pt-BR pairs) so it matches behavior already in the product—no code changes.
REST credential egress (#1977 / #2006): Docs now cover target-level
pass_from_env,password_from_env, anduser_from_envalongside auth-block env secrets. They state thatauth.allowed_hostsis still required while any*_from_envkey remains, even after the loader copies values intopass/user. REST env var names must useAPI_/REST_API_/DATA_BOAR_prefixes; SQL/NoSQL/sharepass_from_env(e.g.DEMO_DB_PASSWORD) is explicitly not on that list. USAGE adds a YAML example for Basic auth viauser+pass_from_env; troubleshooting and credentials guides point totests/test_rest_connector_pass_from_env_loader.py.Power BI / Dataverse (#2007): New sections document that client-secret token POSTs are only allowed to
https://login.microsoftonline.com(https, exact host, no userinfo). Sovereign-cloud hosts fail closed with#2007before POST—separate from REST#1977.Scan failure reasons: Troubleshooting tables add rows for
#2007,missing_optional_dependency(optional extras likenosql/shares—not TCPunreachable), and expand the#1977row for RESTpass_from_env.Lab completão: Runbooks document host-smoke prepare using
scripts/rc_bench_extras.py(list/verify), RC v3 extras sync, and that missingnosqlyieldsmissing_optional_dependency(RC sentinel fail, not SKIP).Mongo/Redis: TECH_GUIDE notes missing
.[nosql]recordsmissing_optional_dependencyinstead ofunreachable.Reviewed by Cursor Bugbot for commit e437fd0. Bugbot is set up for automated code reviews on this repo. Configure here.