Repository navigation
Test on Ruby 4.0 in CI and rename an obsolete RuboCop cop key - #168
Merged
Merged
Conversation
Found in the final verification after the Dependabot merges. - The dev-tools bump (#152) brought unicode-emoji 4.3, which allows Ruby 4.0. The suite passes on 4.0.7 (735 examples), so the matrix becomes ['3.4', '4.0'] and the comment saying 4.0 is blocked goes. - RuboCop 1.91 renamed Naming/PredicateName to Naming/PredicatePrefix and warned on every run; the todo entry uses the new name. - getting-started points at the workflow for the tested versions instead of naming them; the doc spec now skips CHANGELOG for the hard-coded-version check, since a changelog names versions on purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes found in the final check after all the PRs were merged.
Ruby 4.0 in CI
The dev-tools bump (#152) upgraded
unicode-emojito 4.3.0. The old 4.0.4 required Ruby below 4.0, which was why 4.0 was left out of CI. In a fresh clone the suite now passes on Ruby 4.0.7: 735 examples, 0 failures.['3.4', '4.0']on Ubuntu and macOS.test.ymlcomment saying 4.0 is blocked is removed.docs/getting-started.mdnow points at the workflow file for the tested versions instead of naming them, so the doc can't drift.CHANGELOG.mdwhen checking for hard-coded Ruby versions. A changelog names versions on purpose.Obsolete cop key
RuboCop 1.91 renamed
Naming/PredicateNametoNaming/PredicatePrefix, and it warned on every run. The entry in.rubocop_todo.ymlnow uses the new name, and the warning is gone.Tested
bundle exec rspec: 735 examples, 0 failures.bundle exec rubocop: exits 0, with no warnings.