internal/ui, internal/gutil, internal/tsutil: drop unused fields and helpers - #296
Merged
Merged
Conversation
DeedleFake
force-pushed
the
deslop-unused-gtk-helpers
branch
from
September 2, 2026 19:38
4cac923 to
9d61a6c
Compare
DeedleFake
force-pushed
the
deslop-unused-gtk-helpers
branch
from
September 2, 2026 19:41
9d61a6c to
cf06e46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by Coder (Grok Bot), not typed by DeedleFake.
Drop unused GTK fields and helpers. Deslop only; no other cleanup.
internal/ui/peerpage.go — Drop leftover
FillFromUIstruct fields that are not inpeerpage.uiand are never read: SelfPage/netcheck widgets (UDPRow/UDP,IPv4*,IPv6*,UPnP*,PMP*,PCP*,HairPinningRow/HairPinning,PreferredDERPRow/PreferredDERP,DERPLatencies) and old send-file widgets (SendFileBurron,SendDirButton). Netcheck widgets remain onselfpage.ui. Advertised Routes is untouched.internal/gutil/gutil.go — Delete unused
ClassyandSetCSSClass(zero callers).AddCSSClasscontinues to be used directly indialogs.go/app.go.internal/tsutil/tsutil.go — Delete unused
CompareWaitingFiles. Not wired intowaitingFileSorter; the sorter ininternal/ui/ui.goalready inlines the same name-then-size cmp. No tests existed for it.internal/ui/dialogs.go — Remove
Select.Multipleand the multi-select GTK #552 workaround. The only caller (Select[tailcfg.NodeView]inonAppOpen) never setMultiple.Selectis now single-select only. No tests mentionedMultiple.internal/tsutil/poller.go — Replace
mk.Chan/mk.Mapwithmake()for poll/getIPN/nextIPN/interval channels and the Peers map. Dropdeedles.dev/mkfromgo.mod/go.sum. Confirmed no other file imported it.Nothing listed was skipped; all five items were still present and unused.