Skip to content

internal/ui, internal/gutil, internal/tsutil: drop unused fields and helpers - #296

Merged
DeedleFake merged 3 commits into
masterfrom
deslop-unused-gtk-helpers
Sep 2, 2026
Merged

DeedleFake merged 3 commits into
masterfrom
deslop-unused-gtk-helpers

Conversation

@DeedleFake

@DeedleFake DeedleFake commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Opened by Coder (Grok Bot), not typed by DeedleFake.

Drop unused GTK fields and helpers. Deslop only; no other cleanup.

  1. internal/ui/peerpage.go — Drop leftover FillFromUI struct fields that are not in peerpage.ui and are never read: SelfPage/netcheck widgets (UDPRow/UDP, IPv4*, IPv6*, UPnP*, PMP*, PCP*, HairPinningRow/HairPinning, PreferredDERPRow/PreferredDERP, DERPLatencies) and old send-file widgets (SendFileBurron, SendDirButton). Netcheck widgets remain on selfpage.ui. Advertised Routes is untouched.

  2. internal/gutil/gutil.go — Delete unused Classy and SetCSSClass (zero callers). AddCSSClass continues to be used directly in dialogs.go / app.go.

  3. internal/tsutil/tsutil.go — Delete unused CompareWaitingFiles. Not wired into waitingFileSorter; the sorter in internal/ui/ui.go already inlines the same name-then-size cmp. No tests existed for it.

  4. internal/ui/dialogs.go — Remove Select.Multiple and the multi-select GTK #552 workaround. The only caller (Select[tailcfg.NodeView] in onAppOpen) never set Multiple. Select is now single-select only. No tests mentioned Multiple.

  5. internal/tsutil/poller.go — Replace mk.Chan/mk.Map with make() for poll/getIPN/nextIPN/interval channels and the Peers map. Drop deedles.dev/mk from go.mod/go.sum. Confirmed no other file imported it.

Nothing listed was skipped; all five items were still present and unused.

@DeedleFake DeedleFake changed the title Drop unused GTK fields and helpers meta: drop unused GTK fields and helpers Sep 2, 2026
@DeedleFake
DeedleFake force-pushed the deslop-unused-gtk-helpers branch from 4cac923 to 9d61a6c Compare September 2, 2026 19:38
@DeedleFake DeedleFake changed the title meta: drop unused GTK fields and helpers internal/ui, internal/gutil, internal/tsutil: drop unused fields and helpers Sep 2, 2026
@DeedleFake
DeedleFake force-pushed the deslop-unused-gtk-helpers branch from 9d61a6c to cf06e46 Compare September 2, 2026 19:41
@DeedleFake
DeedleFake merged commit 7060302 into master Sep 2, 2026
3 checks passed
@DeedleFake
DeedleFake deleted the deslop-unused-gtk-helpers branch September 2, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant