fix(mcp): exit stdio server on parent death#407
Open
nvt-pankajsharma wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406
Summary
Scope
getppid()polling.Validation
make -f Makefile.cbm cbm && bash tests/test_parent_watchdog.shscripts/test.shscripts/lint.sh --ciscripts/build.sh CC=cc CXX=c++make -f Makefile.cbm securitygit diff --cached --checkNote: the security target prints stale absolute paths during vendored integrity scanning, but it exits successfully with
Vendored integrity check passedandAll security checks passed.Local hook note
git commitwithout--no-verifyran the repository pre-commit hook and failed in unrelated existingclang-tidyfindings outside this PR's files, includinginternal/cbm/cbm.c,src/store/store.c,src/watcher/watcher.c, andsrc/pipeline/pass_lsp_cross.h. The contribution checklist commands above passed on this branch.