Repository navigation
ci: fix macOS codesign failure and nuget-publish skip on workflow_dispatch - #22
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoSep 16, 2026
Conversation
…patch - Stage-MacOsApp.ps1: move (not copy) the third-party notices files into Contents/Resources instead of leaving duplicates in Contents/MacOS. Apple's codesign treats stray non-executable files sitting next to the main executable in Contents/MacOS as nested code requiring their own signature, which made 'codesign ... Devolutions.Terminal' fail with 'code object is not signed at all / In subcomponent: ...GHOSTTY.txt' during the macOS sign and notarize jobs. - Test-MacOsPackage.ps1: updated to expect the notices files under Contents/Resources to match the new layout. - build-terminal.yml: align the nuget-publish job's if condition with the other release jobs (macos-sign, release) so it also runs on workflow_dispatch, not only on tag pushes. Previously it was skipped on every workflow_dispatch run (as seen in run 35150675662) even when dry_run was false, because github.ref never starts with refs/tags/ for a workflow_dispatch trigered from a branch.
Marc-André Moreau (mamoreau-devolutions)
requested a review
from a team
as a code owner
September 16, 2026 21:28
Marc-André Moreau (mamoreau-devolutions)
merged commit Sep 16, 2026
924f627
into
master
12 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
copilot/fix-macos-sign-nuget-publish
branch
September 16, 2026 21:29
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
September 16, 2026 21:33 — with
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
September 16, 2026 21:33 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes two failures from run #35150675662 (
Build Terminal, manualworkflow_dispatchonmaster):1.
macOS sign and notarize osx-x64/osx-arm64failedStage-MacOsApp.ps1copied the notices files intoContents/Resourcesbut also left a duplicate copy sitting inContents/MacOS, alongside the main executable.codesign, when given the path to the bundle's main executable, resolves and signs the whole app bundle, and treats stray non-executable files left inContents/MacOS(a directory that's supposed to contain only executables/helper tools) as nested code requiring their own signature — which a plain.txtfile obviously can't have, so signing failed.Fix:
Move-Iteminstead ofCopy-Itemfor the notices files, so they only exist underContents/Resources(matching Apple's bundle layout conventions). UpdatedTest-MacOsPackage.ps1's required-file check to match the new location.2.
Publish Devolutions.Terminal.Control to nuget.orgwas skippedIts condition was:
This run was a manual
workflow_dispatchonmaster, sogithub.refisrefs/heads/master, neverrefs/tags/*— the job is unconditionally skipped for everyworkflow_dispatchrun, dry-run or not. Every other release-type job (macos-sign,release) already uses the patterngithub.event_name == 'workflow_dispatch' || startsWith(github.ref, 'refs/tags/')to allow both triggers.Fix: align
nuget-publish's condition with that same pattern, so it runs for non-dry-runworkflow_dispatchruns too, not just tag pushes.Testing
python -c "import yaml; yaml.safe_load(open('.github/workflows/build-terminal.yml'))"— YAML parses.Parser.ParseFileon both edited scripts — no syntax errors.codesignerror and is consistent with the general macOS bundle-layout rule thatContents/MacOSshould only contain executables.