Repository navigation
ci: fix macOS codesign "In subcomponent" failure in release signing - #24
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoSep 16, 2026
Conversation
Sign-MacOsPackage.ps1 signed every Mach-O file individually, including the bundle's main executable (Contents/MacOS/Devolutions.Terminal). Signing a bundle's main executable as a standalone file makes codesign operate in bundle context and require every sibling file in Contents/MacOS (e.g. dt.runtimeconfig.json, which is not code) to already carry a signature, failing with 'code object is not signed at all / In subcomponent: ...'. Skip the main executable (resolved from CFBundleExecutable in Info.plist) during per-file signing; signing the bundle itself at the end signs the main executable and applies the entitlements to it, which is Apple's recommended flow.
Marc-André Moreau (mamoreau-devolutions)
merged commit Sep 16, 2026
81ef175
into
master
12 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
copilot/fix-ci-run-35154262459
branch
September 16, 2026 22:08
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
September 16, 2026 22:11 — with 
GitHub Actions
Active
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
September 16, 2026 22:12 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Build Terminalrun 35154262459 (workflow_dispatch release) failed in bothmacOS sign and notarizejobs at theSign, package, and notarizestep:Note: the sign jobs only run on
workflow_dispatch, which is why pushes on the same commit were green — this was the first real exercise of the signing path.Root cause
scripts/Sign-MacOsPackage.ps1signed every Mach-O file in the bundle individually, including the bundle's main executable (Contents/MacOS/Devolutions.Terminal). When codesign is pointed at a bundle's main executable as a standalone file, it operates in bundle context and requires every sibling inContents/MacOS/to already be signed nested code.dt.runtimeconfig.jsonis a data file, not signable code, so codesign bails out.Fix
Skip the main executable (resolved from
CFBundleExecutablein the bundle'sInfo.plist) during per-file signing. The final bundle-levelcodesign— which the script already performs with--entitlements— signs the main executable and applies the entitlements to it. This is Apple's recommended inside-out flow (sign nested code, then the bundle; never the main executable standalone).Validation
Test-MacOsPackagingMetadata.ps1runs in CI).Build Terminalworkflow_dispatch after merge.