Skip to content

identifies PWADs lumps shorter than 16 bytes a EDATA instead of ELUMP #84

Description

@fabiangreffrath

Because of this seemingly random distinction, deutex -x SD21-Classic.wad fails to extract the COMPLVL lump which contains the string "MBF21", and is thus merely 6 bytes long. This lead to a lot of confusion when trying to debug why Woof would forcefully set a complevel when this PWAD is loaded.

deutex/src/ident.c

Lines 913 to 916 in 870ca04

if (info->dir[n].size > 16)
IDENTsetType(ids, info, n, ELUMP);
else
IDENTsetType(ids, info, n, EDATA);

I'd suggest reducing the requirement to count as a "real lump" to > 0, in order to keep mere label lumps out of the list of extracted files. Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions