refactor: 도메인별 dto 패키지를 request/response로 분리 - #429
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
dto패키지를dto/request,dto/response하위 패키지로 분리했습니다. (menu 도메인은 이미presentation/dto/request,presentation/dto/response로 분리되어 있어 참고 패턴으로만 삼고 이번 변경에서 제외했습니다.)*Request/*RequestV2접미사 파일 →dto/request*Response/*ResponseV2접미사 파일 →dto/responseBaseResponse/SliceResponse로 직접 반환하는 것으로 실사용처를 확인한 클래스(MenuBoard,MenuBoards,MenuLine,MenuSection,MealSection,ReportLine,InquiryLine,PartnershipInfo,ReportTypeList,ReportTypeInformation,ReviewDetail,ReviewDetailV1,MenuIdNameDto,MenuIdNameLikeDto,SavedReviewImage,Tokens,MyReviewDetail등) →dto/responseBriefMenu,RatingsDto,MealInfo,OAuthInfo,AppleKeys,SectionInBoard,ReviewRatingCount,RatingAverages)는dto루트에 그대로 유지ControllerDocs인터페이스, 테스트 코드의 import 문을 함께 수정했습니다.💬 공유사항 to 리뷰어
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.