Repository navigation
Adjust element indexing in molecular_graph.py - #37
Merged
Merged
Conversation
akalikadien
self-requested a review
November 12, 2025 11:58
akalikadien
approved these changes
Nov 12, 2025
akalikadien
left a comment
akalikadien
left a comment
Member
There was a problem hiding this comment.
Good catch, this piece of code gets triggered if Morfeus objects have atomic elements as digits instead of strings. The conversion of integers to strings would indeed go wrong because of this indexing error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug which adds 1 to the atomic numbers of the extracted complex structure