SchemaAnalyzer: ensure identical order of elements#128
Open
barsnick wants to merge 1 commit into
Open
Conversation
xmlschema stores substitution groups as set[XsdElement] and iterates them directly. Those XsdElement instances are object-hashed, so PYTHONHASHSEED=0 does not stabilize their order. A harmless Python source change can alter object allocation/timing, which changes set iteration order, which then changes generated type/function/grammar order. The SchemaAnalyzer now sorts substitution-group elements before consuming them, using stable schema data: element qualified name plus type name. Fixes #84. Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
SebaLukas
approved these changes
May 20, 2026
SebaLukas
left a comment
SebaLukas
left a comment
Member
There was a problem hiding this comment.
The changes looking good! I just haven't tested it 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xmlschema stores substitution groups as
set[XsdElement]and iterates them directly. Those XsdElement instances are object-hashed, soPYTHONHASHSEED=0does not stabilize their order. A harmless Python source change can alter object allocation/timing, which changes set iteration order, which then changes generated type/function/grammar order.Describe your changes
The SchemaAnalyzer now sorts substitution-group elements before consuming them, using stable schema data: element qualified name plus type name.
Issue ticket number and link
Fixes #84.
Checklist before requesting a review