chore(radio): remove 20% deadband for low volume#7347
Conversation
…me limitation to something more generic
|
@coderabbitai review please |
|
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughRefactors speaker volume input from hysteresis to a deadzone-based mapping, adds per-target VOLUME_LEVEL_MAX overrides, lowers TAS2505 VOLUME_MIN_DB with added trace logging, and has the board driver pass unscaled volume to the TAS2505 driver. ChangesAudio Volume Control Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This improves settings sound level by special function or sound settings by source. It reduces the dead band before any sound can be played (previously volume was set a 0 until at least -80%)
This also simplifies the mechanic when hardware needs a fixed volume limitation
Summary by CodeRabbit
Bug Fixes
New Features
Chores