Add scripts.json with entries, categories, tags, and locally-stored images#51
Conversation
Claude AI update of JSON from README.md and GAMES.md content. Also update the categories, and add tags. Needs manual review and update of the categories of the tags/labels.
Prevent broken image links due to external changes, JWT expiry, etc
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughMoves many README and games.md preview images from external URLs to local ChangesAsset Migration to Local Hosting
Script Catalog Schema Restructuring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
175-177:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUse local
ASSETSimages for VB Telemetry and RCIC sections.These lines still use external attachment URLs, which conflicts with the stated local-image migration and reintroduces link-rot risk.
Suggested fix
-<img width="256" height="128" alt="image" src="https://github.com/user-attachments/assets/9c29e013-f0be-4e61-8900-71d0906d030e" /> -<img width="256" height="128" alt="image" src="https://github.com/user-attachments/assets/f05f9c1c-12fa-4e06-848b-c8fdc48231e9" /> -<img width="256" height="128" alt="image" src="https://github.com/user-attachments/assets/46541ae9-f6f6-436a-8eee-97fdc799badc" /> +<img src="ASSETS/vb-telemetry/screenshot-1.png" width="256" alt="VB Telemetry screenshot 1" /> +<img src="ASSETS/vb-telemetry/screenshot-3.png" width="256" alt="VB Telemetry screenshot 2" /> +<img src="ASSETS/vb-telemetry/screenshot-5.png" width="256" alt="VB Telemetry screenshot 3" />-<img width="288" height="144" alt="RCIC Battery page" src="https://github.com/user-attachments/assets/f4148f3f-0a61-4153-87d7-569a8c24495b" /> -<img width="288" height="144" alt="RCIC GPS page" src="https://github.com/user-attachments/assets/c5aca0e8-81c5-413d-9ac9-a969e6944956" /> -<img width="288" height="144" alt="RCIC Location page" src="https://github.com/user-attachments/assets/9da64922-fe4e-4239-a54b-b3af538cc1aa" /> -<img width="288" height="144" alt="RCIC Totals page" src="https://github.com/user-attachments/assets/89e6f037-4b86-4a1c-a0d2-6e8343a1fd2b" /> -<img width="288" height="144" alt="RCIC Configuration page" src="https://github.com/user-attachments/assets/6c0a3e8f-e3e7-46f3-b6e6-452d6356f61f" /> +<img src="ASSETS/rcic/screenshot-1.webp" width="288" alt="RCIC Battery page" /> +<img src="ASSETS/rcic/screenshot-3.webp" width="288" alt="RCIC GPS page" /> +<img src="ASSETS/rcic/screenshot-5.webp" width="288" alt="RCIC Location page" /> +<img src="ASSETS/rcic/screenshot-7.webp" width="288" alt="RCIC Totals/Configuration page" />Also applies to: 187-191
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 175 - 177, The README still references external attachment URLs in the three <img> tags (and the similar block at lines 187-191) for the "VB Telemetry" and "RCIC" sections; replace those src attributes with the local ASSETS image paths used by our repo (e.g., ./assets/<filename> or ASSETS/<filename>) so images are stored and served from this repo instead of github user-attachments, update the two affected blocks of <img> tags in README.md accordingly, and ensure the referenced image files are added to the repo under the ASSETS directory and committed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 486-488: Replace the literal regex placeholder string
ASSETS/hardware_extension_widget_(\d)\.png in the three image references (the
lines with alt texts "Hardware extension widget controls", "Hardware extension
widget settings", and "Hardware extension widget mapping") with the actual
concrete asset filenames (for example ASSETS/hardware_extension_widget_1.png,
ASSETS/hardware_extension_widget_2.png, ASSETS/hardware_extension_widget_3.png
or the real file names in the repo) so the Markdown image links point to real
files and will render.
In `@scripts.json`:
- Around line 672-674: Replace the incorrect flat image paths like
"ASSETS/multiswitch_widget_1.png", "ASSETS/multiswitch_widget_2.png",
"ASSETS/multiswitch_widget_3.png" with the repo's canonical structure using a
slug subfolder and screenshot naming (e.g.
"ASSETS/multiswitch/screenshot-1.png", "ASSETS/multiswitch/screenshot-2.png",
"ASSETS/multiswitch/screenshot-3.png"); do the same replacement for the other
multiswitch/hardware/virtual widget entries mentioned (the similar groups at the
other locations) so they follow ASSETS/<slug>/screenshot-*.png and match
README.md expectations.
- Line 720: Replace the external GitHub blob image URL
("https://github.com/calmarc/EdgeTX-Widgets/blob/master/images/screenshot.png")
in scripts.json with a repository-relative asset reference that uses the ASSETS
path (e.g., ASSETS/images/screenshot.png); locate the string in scripts.json and
update it to point to the local ASSETS entry and ensure the referenced file
exists in the ASSETS/images directory and matches the expected filename.
---
Outside diff comments:
In `@README.md`:
- Around line 175-177: The README still references external attachment URLs in
the three <img> tags (and the similar block at lines 187-191) for the "VB
Telemetry" and "RCIC" sections; replace those src attributes with the local
ASSETS image paths used by our repo (e.g., ./assets/<filename> or
ASSETS/<filename>) so images are stored and served from this repo instead of
github user-attachments, update the two affected blocks of <img> tags in
README.md accordingly, and ensure the referenced image files are added to the
repo under the ASSETS directory and committed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bd73cebc-3ba5-4a7d-8bee-fbf0cd52f65b
⛔ Files ignored due to path filters (117)
ASSETS/battery-and-connection-bars-widgets/screenshot-1.pngis excluded by!**/*.pngASSETS/battery-percentage-and-mah-used/screenshot-1.pngis excluded by!**/*.pngASSETS/battery-percentage-and-mah-used/screenshot-3.pngis excluded by!**/*.pngASSETS/betaflight-setup/screenshot-1.jpgis excluded by!**/*.jpgASSETS/edgetx-goodies/screenshot-1.pngis excluded by!**/*.pngASSETS/edgetx-goodies/screenshot-2.pngis excluded by!**/*.pngASSETS/edgetx-goodies/screenshot-3.pngis excluded by!**/*.pngASSETS/edgetx-goodies/screenshot-4.pngis excluded by!**/*.pngASSETS/expresslrs-configurator/screenshot-1.jpgis excluded by!**/*.jpgASSETS/expresslrs-configurator/screenshot-3.pngis excluded by!**/*.pngASSETS/expresslrs-rf-telemetry-widget-for-fixed-wing-heli/screenshot-1.gifis excluded by!**/*.gifASSETS/expresslrs-signal-battery-widgets-for-colorlcd/screenshot-1.jpgis excluded by!**/*.jpgASSETS/expresslrs-telemetry-widget-betaflight-inav/screenshot-1.pngis excluded by!**/*.pngASSETS/f3a-caller/screenshot-1.pngis excluded by!**/*.pngASSETS/f3a-caller/screenshot-3.pngis excluded by!**/*.pngASSETS/flylog-telelog/screenshot-1.pngis excluded by!**/*.pngASSETS/flylog-telelog/screenshot-3.pngis excluded by!**/*.pngASSETS/flylog-telelog/screenshot-5.pngis excluded by!**/*.pngASSETS/fm2m-digital-clock/screenshot-1.pngis excluded by!**/*.pngASSETS/fm2m-digital-clock/screenshot-3.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-1.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-11.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-13.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-15.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-17.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-19.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-3.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-5.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-7.pngis excluded by!**/*.pngASSETS/fm2m-toolbox/screenshot-9.pngis excluded by!**/*.pngASSETS/fm2m-widgets-pack/screenshot-1.pngis excluded by!**/*.pngASSETS/galuaxian/screenshot-1.jpegis excluded by!**/*.jpegASSETS/galuaxian/screenshot-3.jpegis excluded by!**/*.jpegASSETS/galuaxian/screenshot-5.pngis excluded by!**/*.pngASSETS/gps-logger-bw-only/screenshot-1.pngis excluded by!**/*.pngASSETS/gps-logger-color-only/screenshot-1.jpgis excluded by!**/*.jpgASSETS/gps-plus-code-home-arrow-and-avgbatt-widgets/screenshot-1.pngis excluded by!**/*.pngASSETS/gps-plus-code-home-arrow-and-avgbatt-widgets/screenshot-3.pngis excluded by!**/*.pngASSETS/gps-plus-code-home-arrow-and-avgbatt-widgets/screenshot-5.pngis excluded by!**/*.pngASSETS/gps-qr-code-generator/screenshot-1.pngis excluded by!**/*.pngASSETS/gps-qr-code-generator/screenshot-3.pngis excluded by!**/*.pngASSETS/gps-viewer/screenshot-1.pngis excluded by!**/*.pngASSETS/gps-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/gps-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/hardware-extension-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/hardware-extension-widget/screenshot-2.pngis excluded by!**/*.pngASSETS/hardware-extension-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/impexp/screenshot-1.pngis excluded by!**/*.pngASSETS/inav-telemetry-flight-status/screenshot-1.pngis excluded by!**/*.pngASSETS/inav-telemetry-flight-status/screenshot-3.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-1.bmpis excluded by!**/*.bmpASSETS/lap-timer/screenshot-11.bmpis excluded by!**/*.bmpASSETS/lap-timer/screenshot-3.bmpis excluded by!**/*.bmpASSETS/lap-timer/screenshot-5.bmpis excluded by!**/*.bmpASSETS/lap-timer/screenshot-7.bmpis excluded by!**/*.bmpASSETS/lap-timer/screenshot-9.bmpis excluded by!**/*.bmpASSETS/log-viewer-bw-only/screenshot-1.jpgis excluded by!**/*.jpgASSETS/log-viewer/screenshot-1.gifis excluded by!**/*.gifASSETS/log-viewer/screenshot-3.pngis excluded by!**/*.pngASSETS/log-viewer/screenshot-5.pngis excluded by!**/*.pngASSETS/log-viewer/screenshot-7.pngis excluded by!**/*.pngASSETS/log-viewer/screenshot-9.pngis excluded by!**/*.pngASSETS/logmanager/screenshot-1.jpgis excluded by!**/*.jpgASSETS/logmanager/screenshot-3.jpgis excluded by!**/*.jpgASSETS/logviz/screenshot-1.jpgis excluded by!**/*.jpgASSETS/logviz/screenshot-3.jpgis excluded by!**/*.jpgASSETS/lua-fpv-simulator/screenshot-1.pngis excluded by!**/*.pngASSETS/lua-fpv-simulator/screenshot-3.pngis excluded by!**/*.pngASSETS/lua-fpv-simulator/screenshot-5.pngis excluded by!**/*.pngASSETS/multi-protocol-module-tools/screenshot-1.jpgis excluded by!**/*.jpgASSETS/multi-protocol-module-tools/screenshot-3.jpgis excluded by!**/*.jpgASSETS/multi-protocol-module-tools/screenshot-5.jpgis excluded by!**/*.jpgASSETS/multiswitch-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/multiswitch-widget/screenshot-2.pngis excluded by!**/*.pngASSETS/multiswitch-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/rgb-throttle-indicator/screenshot-1.jpgis excluded by!**/*.jpgASSETS/show-it-all/screenshot-1.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-1.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-11.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-13.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-3.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-5.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-7.pngis excluded by!**/*.pngASSETS/spektrum-dsm-tools/screenshot-9.jpgis excluded by!**/*.jpgASSETS/stick-commands/screenshot-1.bmpis excluded by!**/*.bmpASSETS/stick-commands/screenshot-3.bmpis excluded by!**/*.bmpASSETS/switch2-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/switch2-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/switchoverview/screenshot-1.pngis excluded by!**/*.pngASSETS/taranitunes/screenshot-1.pngis excluded by!**/*.pngASSETS/taranitunes/screenshot-3.pngis excluded by!**/*.pngASSETS/taranitunes/screenshot-5.pngis excluded by!**/*.pngASSETS/taranitunes/screenshot-7.pngis excluded by!**/*.pngASSETS/tetris/screenshot-1.jpgis excluded by!**/*.jpgASSETS/tetris/screenshot-3.jpgis excluded by!**/*.jpgASSETS/tswitch-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/tswitch-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/txbattele/screenshot-1.gifis excluded by!**/*.gifASSETS/vb-telemetry/screenshot-1.pngis excluded by!**/*.pngASSETS/vb-telemetry/screenshot-3.pngis excluded by!**/*.pngASSETS/vb-telemetry/screenshot-5.pngis excluded by!**/*.pngASSETS/virtual-controls-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/virtual-controls-widget/screenshot-2.pngis excluded by!**/*.pngASSETS/virtual-controls-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/vu-fullscreen-image-viewer-widget/screenshot-1.jpgis excluded by!**/*.jpgASSETS/vu-fullscreen-image-viewer-widget/screenshot-3.jpgis excluded by!**/*.jpgASSETS/vu-fullscreen-image-viewer-widget/screenshot-5.jpgis excluded by!**/*.jpgASSETS/vu-fullscreen-image-viewer-widget/screenshot-7.jpgis excluded by!**/*.jpgASSETS/widget-for-voltage-and-current-telemetry-mahre2/screenshot-1.pngis excluded by!**/*.pngASSETS/widget-for-voltage-and-current-telemetry-mahre2/screenshot-3.pngis excluded by!**/*.pngASSETS/widget-for-voltage-and-current-telemetry-mahre2/screenshot-5.pngis excluded by!**/*.pngASSETS/widget-for-voltage-and-current-telemetry-mahre2/screenshot-7.pngis excluded by!**/*.pngASSETS/yaapu-horus-mapping-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/yaapu-telemetry-widget/screenshot-1.pngis excluded by!**/*.pngASSETS/yaapu-telemetry-widget/screenshot-3.pngis excluded by!**/*.pngASSETS/yaapu-telemetry-widget/screenshot-5.pngis excluded by!**/*.pngASSETS/yaapu-telemetry-widget/screenshot-7.pngis excluded by!**/*.png
📒 Files selected for processing (8)
.gitignoreASSETS/rcic/screenshot-1.webpASSETS/rcic/screenshot-3.webpASSETS/rcic/screenshot-5.webpASSETS/rcic/screenshot-7.webpREADME.mdgames.mdscripts.json
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@games.md`:
- Around line 4-5: The two new Markdown image links currently have empty alt
text; update each image tag (e.g., the entries referencing
ASSETS/tetris/screenshot-1.jpg and ASSETS/tetris/screenshot-3.jpg) to include
concise, descriptive alt text that conveys the content (for example "Tetris
gameplay showing falling pieces" or similar). Repeat this fix for the other
affected image entries referenced in the comment (the image blocks around lines
12-14 and 17-21) so no image uses an empty alt attribute and MD045 is satisfied.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bbae75c8-6a69-4e14-b9fa-2bbff2bcaa8f
⛔ Files ignored due to path filters (2)
ASSETS/galuaxian/screenshot-7.pngis excluded by!**/*.pngASSETS/galuaxian/screenshot-9.pngis excluded by!**/*.png
📒 Files selected for processing (3)
README.mdgames.mdscripts.json
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts.json
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 15-16: The HTML <img> tags in the README lack alt attributes
causing MD045 and accessibility issues; update every raw <img src="...">
instance (e.g., the screenshot-*.jpg/png tags) to include a concise, descriptive
alt="..." value that summarizes the image (e.g., alt="ExpressLRS Configurator —
main screen" or specific screenshot context), ensuring all occurrences listed in
the review use meaningful alt text consistent with surrounding captions or
headings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 85421910-cf21-4311-a9e1-96cd2f88af3a
⛔ Files ignored due to path filters (8)
ASSETS/lap-timer/screenshot-1.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-11.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-3.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-5.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-7.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-9.pngis excluded by!**/*.pngASSETS/stick-commands/screenshot-1.pngis excluded by!**/*.pngASSETS/stick-commands/screenshot-3.pngis excluded by!**/*.png
📒 Files selected for processing (2)
README.mdscripts.json
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts.json
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 313-314: The image alt texts in README.md are currently
filename-style labels (e.g. "screenshot_zorro_25-06-15_13-22-16" and
"screenshot_zorro_25-06-15_13-22-37"); replace those alt strings in the two
markdown image links with concise, semantic descriptions (for example "Log
visualization timeline view" and "Log visualization detail view" or similarly
accurate captions) so the markdown image references convey meaningful,
accessible information.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f99f6d03-e1a3-43fd-86ec-94d9a9154e42
⛔ Files ignored due to path filters (8)
ASSETS/lap-timer/screenshot-1.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-11.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-3.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-5.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-7.pngis excluded by!**/*.pngASSETS/lap-timer/screenshot-9.pngis excluded by!**/*.pngASSETS/stick-commands/screenshot-1.pngis excluded by!**/*.pngASSETS/stick-commands/screenshot-3.pngis excluded by!**/*.png
📒 Files selected for processing (3)
README.mdgames.mdscripts.json
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Improvements
Chores