Repository navigation
Preserve OBJECT type for bound NULL in INSERT VALUES - #156
Merged
osipovartem merged 1 commit intoOct 20, 2026
Merged
Conversation
osipovartem
marked this pull request as ready for review
October 20, 2026 23:06
osipovartem
merged commit Oct 20, 2026
d9895a7
into
df55-array-insert-coercion
33 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Rustice REST wire test
connector_object_bindings_reject_scalars_and_accept_nullreached the Iceberg sink with a physical Null VALUES field forINSERT INTO t(payload OBJECT) VALUES (:1)when:1was bound asANY = NULL; the sink rejected the schema. DataFusion'sreplace_params_with_valuesrebuilds VALUES after substitution. The target field has OBJECT metadata and Utf8 storage, butScalarValue::Nullloses that physical type.The stock Snowflake Python Connector qmark-bound
Noneinserted successfully into a temporary OBJECT column (1 row, 0 non-NULL payloads) in a focused live check. The oracle warehouse was suspended afterward.Verification
cargo +1.97.0 fmt --all -- --checkcargo +1.97.0 test --profile ci -p datafusion-sql --test sql_integration: 642/642cargo +1.97.0 clippy --profile ci -p datafusion-expr -p datafusion-sql --all-targets -- -D warningsconnector_object_bindings_reject_scalars_and_accept_nullon rev8572b31fce6007348fcd5037cc515a0e7f3e472a: 1/1 passed through the local REST endpoint and Iceberg sink (loopback bind required an unsandboxed test run).This is a narrow follow-up to #155. It does not change the common non-NULL parameter path.