Repository navigation
Instantiate stateful scalar UDFs per physical expression - #158
Merged
osipovartem merged 1 commit intoOct 21, 2026
Merged
Conversation
osipovartem
merged commit Oct 21, 2026
f6ee532
into
df55-bound-null-object-values
33 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Rustice SEQ functions need state shared across Arrow batches in one query but reset for the next query or view execution. A logical UDF instance can survive in saved plans; batch-local state resets too early.
Validation
Scope
This is intentionally a fork-local API. The stable-ABI FFI UDF wrapper does not forward this new hook; plan clones share the same invocation object. Ordinary UDFs retain their existing Arc and do not pay an extra per-batch branch.
CI context
The fork CI currently has unrelated failures outside this three-file diff: CLI integration cannot pull its MinIO image; an existing CSV diagnostic test compares a backtrace-bearing error string; Taplo reports the unchanged
datafusion/datasource/Cargo.toml; generated function docs are stale on the base branch. The targeteddatafusion-physical-exprsuite (1610 passed, 2 ignored), local Rustice integration suite (3850/3850), formatting, and Clippy checks passed. The fork-only FFI limitation remains documented above.